Skip to content

fix(benchmark): opt in to the experimental trace section metric - #1477

Merged
A-EDev merged 1 commit into
mainfrom
fix/benchmark-metric-optin
Oct 28, 2026
Merged

A-EDev merged 1 commit into
mainfrom
fix/benchmark-metric-optin

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • StartupBenchmark opts in to ExperimentalMetricApi. Its TraceSectionMetric("neuro.init") is experimental in the current macrobenchmark, so :benchmark did not compile and neither StartupBenchmark nor :app:generateBaselineProfile could run.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug

  • ./gradlew :app:testGithubDebugUnitTest

  • I ran any additional flavor-specific build or test tasks affected by this change.

  • I manually tested the affected behavior on an Android device or emulator.

  • ./gradlew :benchmark:compileBenchmarkReleaseKotlin: fails on main with "This Metric API is experimental", passes with this change.

  • ./gradlew ktlintCheck spotlessCheck: passed.

  • With this change :benchmark:connectedBenchmarkReleaseAndroidTest (StartupBenchmark coldStartup) and :app:generateBaselineProfile ran on a phone.

Test device and Android version: Xiaomi 2311DRK48G, HyperOS on Android 16

Screenshots or recordings

Risk and compatibility

Benchmark module only; nothing ships in the app.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 27, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev merged commit 0e31296 into main Oct 28, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/benchmark-metric-optin branch October 29, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants