Repository navigation
fix(benchmark): opt in to the experimental trace section metric - #1477
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
9 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StartupBenchmarkopts in toExperimentalMetricApi. ItsTraceSectionMetric("neuro.init")is experimental in the current macrobenchmark, so:benchmarkdid not compile and neitherStartupBenchmarknor:app:generateBaselineProfilecould run.Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTestI ran any additional flavor-specific build or test tasks affected by this change.
I manually tested the affected behavior on an Android device or emulator.
./gradlew :benchmark:compileBenchmarkReleaseKotlin: fails on main with "This Metric API is experimental", passes with this change../gradlew ktlintCheck spotlessCheck: passed.With this change
:benchmark:connectedBenchmarkReleaseAndroidTest(StartupBenchmark coldStartup) and:app:generateBaselineProfileran on a phone.Test device and Android version: Xiaomi 2311DRK48G, HyperOS on Android 16
Screenshots or recordings
Risk and compatibility
Benchmark module only; nothing ships in the app.