Repository navigation
fix: remove white line artifacts between lyrics - #1514
Merged
Merged
Conversation
The lyrics panel now paints the configured backdrop color, falling back to the theme background. Individual lyric rows no longer use rounded-corner clipping, and the offset test includes a background lyric row. Fixes Flow-Tube#1484
2 tasks done
Co-Authored-By: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
A-EDev
reviewed
Oct 28, 2026
A-EDev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for picking this up! The lines came from the translucent unsung colour blending twice where Bengali glyphs overlap, not from the row clip or the panel background (both hosts already paint that backdrop).
I pushed a commit that blends the dimmed colours onto the backdrop up front, restores the rounded clip, and adds a nightly note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lyrics can show visible white lines between adjacent lyric rows instead of a continuous background. Each lyric row was clipped to rounded corners, allowing the underlying surface to show through at row boundaries. The lyrics container itself did not explicitly paint the intended backdrop.
The lyrics panel now paints the configured backdrop color, falling back to the theme background. Individual lyric rows no longer use rounded-corner clipping, and the offset test includes a background lyric row.
Related issue
Closes #1484
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTestRan
./gradlew :app:testGithubDebugUnitTestlocally on macOS for the Flow change; it fails the same way on the base branch, so the failure predates this change (it fails the same way on upstream/main). The full GitHub debug unit-test suite ran but failed with 208 failing tests.Screenshots or recordings
No user-visible surface changes in this PR, so there is nothing to show.
Risk and compatibility