Skip to content

fix: remove white line artifacts between lyrics - #1514

Merged
A-EDev merged 3 commits into
Flow-Tube:mainfrom
mvanhorn:fix/1484-lyrics-white-line
Oct 28, 2026
Merged

A-EDev merged 3 commits into
Flow-Tube:mainfrom
mvanhorn:fix/1484-lyrics-white-line

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

Summary

Lyrics can show visible white lines between adjacent lyric rows instead of a continuous background. Each lyric row was clipped to rounded corners, allowing the underlying surface to show through at row boundaries. The lyrics container itself did not explicitly paint the intended backdrop.

The lyrics panel now paints the configured backdrop color, falling back to the theme background. Individual lyric rows no longer use rounded-corner clipping, and the offset test includes a background lyric row.

Related issue

Closes #1484

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest
  • I ran any additional flavor-specific build or test tasks affected by this change.
  • I manually tested the affected behavior on an Android device or emulator.

Ran ./gradlew :app:testGithubDebugUnitTest locally on macOS for the Flow change; it fails the same way on the base branch, so the failure predates this change (it fails the same way on upstream/main). The full GitHub debug unit-test suite ran but failed with 208 failing tests.

Screenshots or recordings

No user-visible surface changes in this PR, so there is nothing to show.

Risk and compatibility

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

The lyrics panel now paints the configured backdrop color, falling back
to the theme background. Individual lyric rows no longer use
rounded-corner clipping, and the offset test includes a background lyric
row.

Fixes Flow-Tube#1484
@mvanhorn
mvanhorn requested a review from A-EDev as a code owner October 28, 2026 11:50
@mvanhorn mvanhorn mentioned this pull request Oct 28, 2026
2 tasks done
@github-actions github-actions Bot added the ui Compose UI, theming, or Material 3 surfaces label Oct 28, 2026
mvanhorn and others added 2 commits October 28, 2026 07:38

@A-EDev A-EDev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! The lines came from the translucent unsung colour blending twice where Bengali glyphs overlap, not from the row clip or the panel background (both hosts already paint that backdrop).
I pushed a commit that blends the dimmed colours onto the backdrop up front, restores the rounded clip, and adds a nightly note.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 28, 2026
@A-EDev
A-EDev merged commit e263196 into Flow-Tube:main Oct 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: white line on lyrics

2 participants