Repository navigation
ci: check the size of the FOSS arm64-v8a APK that IzzyOnDroid ships - #1564
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI size budget measured the wrong APK. IzzyOnDroid ships the FOSS arm64-v8a APK and applies its 30 MB cap to that one, not to the universal APK. For reference, stable v3.0.0's arm64-v8a APK was 19.8 MB. After the linked-devices stack, the universal FOSS APK is over the old check, and #1559's "Build APK" failed on that step.
app-foss-arm64-v8a-release*.apk, with the same 29,500,000 byte budget. Its comment and error message name that APK.Current sizes on
origin/main(5253022), from./gradlew :app:assembleFossReleaserun locally offline. These are unsigned; CI's signed APKs are slightly larger.That leaves arm64-v8a about 7.9 MB under the budget.
Related issue
None.
Change type
Validation
./gradlew :app:assembleFossRelease: ok, sizes above./gradlew :app:assembleGithubDebug: ok./gradlew :app:testGithubDebugUnitTest: 4651 passed, 46 skipped, 0 failed (no code changed)./gradlew ktlintCheck: okruby -ryaml -e 'YAML.load_file(".github/workflows/build.yml")': parsesTest device and Android version: none
Risk and compatibility
The universal FOSS APK is no longer held to a budget. It is still listed in the step summary.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources. (None.)
Dependency and lockfile changes are intentional and limited to this PR. (None.)
Room schema changes include the required version bump and migration, or this PR does not change the Room schema. (No schema change.)
Breaking changes and upgrade steps are clearly documented. (None.)