Skip to content

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Dec 29, 2025

Close #28

Summary by CodeRabbit

  • Chores
    • Internal improvements to reduce external dependencies while preserving all existing functionality and API stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request replaces an external dependency call to StringUtils.isBlank with a private static helper method in ImageCrop.java. This removes the unused Apache Commons Lang3 import and internalizes the null/blank-checking logic while preserving existing behavior.

Changes

Cohort / File(s) Summary
ImageCrop dependency removal
src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java
Removed org.apache.commons.lang3.StringUtils import. Added private static isBlank(String s) helper method. Updated getCroppedImageBase64() to use the new helper for null/blank validation on cropped data URI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lang3-removal

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcec258 and 7b6856d.

📒 Files selected for processing (1)
  • src/main/java/com/flowingcode/vaadin/addons/imagecrop/ImageCrop.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlopezFC mlopezFC merged commit 46391f6 into master Dec 29, 2025
3 of 4 checks passed
@mlopezFC mlopezFC deleted the lang3-removal branch December 29, 2025 17:28
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vaadin 25: Compilation failure

3 participants