fix(chat): honor model end-of-turn tokens - #163
Merged
Conversation
Register Gemma's end-of-turn token alongside generic EOS so natural answers terminate at the model boundary, with a strict repetition guard for malformed streams. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eot_token_id(<turn|>, token 106)Root cause
PR #161 registered only
tokenizer.eos_token_id(Gemma token 1). Gemma-4 actually closes assistant turns withtokenizer.eot_token_id(token 106), so the runtime ignored the natural turn boundary and generated subsequentthoughtchannels and repeated answers.Verification
PYTHONPATH=.:sdks/python pytest -q tests/scripts/test_chat_grpc.py— 6 passedpython -m py_compile scripts/chat_grpc.pyHello!/ 3 tokens /stop=eos/ no repetitionMade with Cursor