Skip to content

fix(agents): bound Critic evidence prefill context - #181

Merged
FluffyAIcode merged 1 commit into
mainfrom
AgentMemory/critic-evidence-window-0717
Jul 16, 2026
Merged

fix(agents): bound Critic evidence prefill context#181
FluffyAIcode merged 1 commit into
mainfrom
AgentMemory/critic-evidence-window-0717

Conversation

@FluffyAIcode

Copy link
Copy Markdown
Owner

Summary

  • preserve full Generator output to EOS in Terminal
  • build a bounded Critic evidence window from Generator beginning and conclusion, defaulting to 128 content tokens
  • include full/evidence/omitted token counts and Generator EOS completion status
  • instruct Critic that evidence omission is a transport constraint, not Generator incompleteness
  • emit an allens Prefill heartbeat every 30 seconds with elapsed time
  • expose evidence metrics in benchmark phase cards and reports

Root cause

A complete Riemann answer produced a 1,166-token Critic prompt. The 16GB allens worker remained active but could not finish Prefill within 900 seconds. Raising timeouts does not make the interaction usable.

Tests

  • evidence full/omitted/budget validation
  • heartbeat elapsed progress
  • stage evidence metrics and Critic gate tests — 11 passed
  • full platform-neutral suite — 857 passed, 1 skipped
  • Python compile and diff checks pass

Made with Cursor

Keep full Generator output in Terminal while feeding Critic an explicit head-tail evidence window with omitted-token metadata, and emit Prefill heartbeats so long allens work remains visibly active.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@FluffyAIcode
FluffyAIcode merged commit 58cee28 into main Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant