Skip to content

fix(agents): accept exact remote KV hits in gate #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FluffyAIcode merged 1 commit into from
Jul 17, 2026
Merged

fix(agents): accept exact remote KV hits in gate #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/agent_gan_inference_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@

def _agent_cache_gate(warm_delta: dict, actual_delta: dict) -> bool:
return (
warm_delta["remote_jobs"] >= 1
and warm_delta["remote_hits"] >= 1
warm_delta["remote_hits"] >= 1
and warm_delta["tokens_reused"] >= 1
and warm_delta["tokens_computed"] == 0
and warm_delta["fallbacks"] == 0
and warm_delta["remote_job_failures"] == 0
and actual_delta["local_hits"] >= 1
and actual_delta["remote_jobs"] == 0
and actual_delta["tokens_computed"] == 0
Expand Down
17 changes: 14 additions & 3 deletions tests/inference_engine/bridge/test_agent_gan_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,27 @@
)


def test_agent_gate_requires_remote_warmup_and_primary_hot_inference():
warm = {"remote_jobs": 1, "remote_hits": 1}
def test_agent_gate_accepts_remote_compute_or_exact_remote_cache_hit():
warm = {
"remote_jobs": 1,
"remote_hits": 1,
"tokens_reused": 10,
"tokens_computed": 0,
"fallbacks": 0,
"remote_job_failures": 0,
}
actual = {
"local_hits": 1,
"remote_jobs": 0,
"tokens_computed": 0,
"fallbacks": 0,
}
assert _agent_cache_gate(warm, actual)
assert not _agent_cache_gate({**warm, "remote_jobs": 0}, actual)
assert _agent_cache_gate({**warm, "remote_jobs": 0}, actual)
assert not _agent_cache_gate({**warm, "remote_hits": 0}, actual)
assert not _agent_cache_gate({**warm, "tokens_reused": 0}, actual)
assert not _agent_cache_gate({**warm, "fallbacks": 1}, actual)
assert not _agent_cache_gate({**warm, "remote_job_failures": 1}, actual)
assert not _agent_cache_gate(warm, {**actual, "local_hits": 0})
assert not _agent_cache_gate(warm, {**actual, "fallbacks": 1})

Expand Down
12 changes: 11 additions & 1 deletion tests/inference_engine/bridge/test_agent_gan_repl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ def test_repl_stage_is_redacted_and_passes_cache_gate():
"remote_jobs": 1,
"remote_hits": 1,
"tokens_reused": 10,
"tokens_computed": 0,
"fallbacks": 0,
"remote_job_failures": 0,
},
}
actual = {
Expand Down Expand Up @@ -101,7 +104,14 @@ def test_stage_includes_full_context_metrics():
warm = {
"prefix_tokens": 10,
"e2e_s": 1,
"delta": {"remote_jobs": 1, "remote_hits": 1, "tokens_reused": 10},
"delta": {
"remote_jobs": 1,
"remote_hits": 1,
"tokens_reused": 10,
"tokens_computed": 0,
"fallbacks": 0,
"remote_job_failures": 0,
},
}
actual = {
"prefix_tokens": 10,
Expand Down
Loading