perf(prefill): export only final MLX snapshot - #191
Merged
Conversation
Eliminate quadratic full-cache serialization by computing every token normally but encoding and compressing only the final chained-prefix snapshot. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The worker previously exported a growing full KV snapshot every 64 tokens. A 1,569-token Critic context therefore performed roughly 25 full exports and compression passes. Since each later snapshot contains a longer prefix, serialization work grew approximately quadratically and made distributed Prefill unusable compared with single-node Prefill.
The final chained hash commits all preceding blocks, so intermediate full snapshots are not required for correctness.
Tests
Made with Cursor