fix(prefill): inject immutable retained-token cap - #201
Merged
Conversation
Make snapshot capacity checks use the worker's configured sink and sliding window directly so missing runtime compatibility fields cannot restore full-prompt estimates. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Exercise constructor validation so the explicit window cap remains fully covered by the strict CI gate. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sink + windowdirectly into PrefillJobStore asmax_retained_tokensRoot cause
The active worker used the correct source and launch arguments, but its runtime capacity path observed a compatibility object with
window_size=0. It therefore estimated2731 * 400000 = 1.0924 GBand rejected the snapshot after a long Prefill. Relying on a serialized compatibility field made the same failure recur after unrelated changes.The explicit deployed cap is
sink + window = 2052, yielding a stable820.8 MBestimate.Tests
Made with Cursor