Skip to content

feat(review): review fields beside their source, correct, approve or reject #8

Closed

Description

@Fluory

Goal

A clerk sees every extracted field with its status and its source, corrects values and approves or rejects the request; every change is audited.

Acceptance criteria

  • Status badges found/uncertain/missing/unverified; unverified and uncertain fields are visually prominent
  • Selecting a field shows the source document at its locator with the quote highlighted (PDF page, mail line)
  • A correction stores old value, new value, user and time as an audit event in the same transaction
  • Approve → APPROVED and export job in the same transaction; reject → REJECTED with a reason
  • Only requests in REVIEW can be approved or rejected

Not part of this task

  • Bulk actions, role-admin UI, near-duplicate hints

Affected areas

  • src/features/review/
  • src/features/requests/
  • src/features/audit/
  • src/app/

Test plan

Criterion Check
transitions unit test of the status machine
audit in transaction integration test
upload → review → approve Playwright smoke in verify:full

Security/Privacy affected?

Role check on every action; no document content in logs.

Epic: #2 · Architecture: docs/decisions/ADR-0001-pilot-architecture.md

Activity

  1. added
    featureNew capability
    readyDefinition of Ready met – may be claimed
    on Sep 22, 2026
  2. self-assigned this
    on Sep 23, 2026
  3. Fluory commented on Sep 23, 2026

    @Fluory
    OwnerAuthor

    Claimed by @Fluory (Claude Code cloud session, overnight run) on branch claude/feat-review-ui-8 – stacked on claude/feat-jobs-worker-7 (#34). Draft PR follows.


    Generated by Claude Code

  4. Fluory commented on Sep 23, 2026

    @Fluory
    OwnerAuthor

    decision-needed – "Selecting a field shows the source document at its locator with the quote highlighted (PDF page, mail line)": the pilot implements this as a text view of the cited PDF page (segments in reading order with their page number, the cited segment and quote highlighted) or of the mail (line numbers, cited line highlighted), plus a link to the original file. A rendered PDF page with a drawn highlight box (pdf.js, bounding boxes are already stored) is the more reversible later step and adds a client-side PDF renderer – please confirm the text view is enough for M1, or ask for the rendered view.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

featureNew capabilityreadyDefinition of Ready met – may be claimed

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions