Skip to content

fix(tests): run the architecture test on Windows #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fluory merged 2 commits into from
Sep 27, 2026
Merged

fix(tests): run the architecture test on Windows #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce2982
fix(tests): start dependency-cruiser through node so the architecture…
Fluory Sep 27, 2026
9c893d4
test(architecture): give the dependency-cruiser cases room on Windows
Fluory Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/architecture/dependency-rules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,22 @@ import { describe, expect, it } from "vitest";

const root = fileURLToPath(new URL("../..", import.meta.url));
const fixture = fileURLToPath(new URL("../fixtures/depcruise", import.meta.url));
const bin = `${root}node_modules/.bin/depcruise`;
// Node runs the package's own entry: `node_modules/.bin/depcruise` is a POSIX shell shim that Windows
// cannot spawn without a shell (ENOENT, #78).
const bin = `${root}node_modules/dependency-cruiser/bin/dependency-cruiser.mjs`;

// Runs the real dependency-cruiser with the project's config against a fixture tree that
// contains one deliberate deep import across modules.
function cruise(entry: string) {
const result = spawnSync(bin, [entry, "--config", `${root}.dependency-cruiser.cjs`, "--no-progress", "--output-type", "err"], {
const result = spawnSync(process.execPath, [bin, entry, "--config", `${root}.dependency-cruiser.cjs`, "--no-progress", "--output-type", "err"], {
cwd: fixture,
encoding: "utf8",
});
return { status: result.status, output: `${result.stdout}${result.stderr}` };
}

describe("module boundary rules", () => {
// Each case starts a real dependency-cruiser run: up to ~5 s on Windows (#87 review), ~1 s on Linux CI.
describe("module boundary rules", { timeout: 20_000 }, () => {
it("rejects a deep import into another module's internals", () => {
const { status, output } = cruise("src/features/alpha");

Expand Down
Loading