feat: add atomic DB transactions for streams + audit + webhooks#200
Merged
Jagadeeshftw merged 2 commits intoApr 24, 2026
Conversation
- streamRepository: add transactionalUpsertStream() and transactionalUpdateStream() each wraps stream write, audit_logs row, and optional webhook_outbox row in a single SQLite transaction; rolls back all three on any failure - auditLog: add buildAuditEntry() + writeAuditEntryToDb() for the transactional write path; replace better-sqlite3 type import with local AuditDbConnection interface; expand AuditAction union to cover STREAM_UPDATED, STREAM_STATUS_UPDATED, PAUSE_FLAGS_UPDATED, REINDEX_TRIGGERED - migrations: add audit_logs + webhook_outbox tables for both SQLite (001_create_streams_table.ts) and PostgreSQL (1774715200000_audit-and-webhook-outbox.ts) - tests: 25 tests across 9 suites covering atomic commit, rollback on stream/audit/webhook failure, idempotent upsert, invalid status transitions, decimal-string precision, and sequential transactions Decimal-string amounts are preserved as TEXT throughout never converted to numbers ensuring full Stellar precision (7 dp) across the chain -> DB -> API boundary.
|
@marvelousufelix Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
streamRepository: add transactionalUpsertStream() and transactionalUpdateStream() each wraps stream write, audit_logs row, and optional webhook_outbox row in a single SQLite transaction; rolls back all three on any failure
auditLog: add buildAuditEntry() + writeAuditEntryToDb() for the transactional write path; replace better-sqlite3 type import with local AuditDbConnection interface; expand AuditAction union to cover STREAM_UPDATED, STREAM_STATUS_UPDATED, PAUSE_FLAGS_UPDATED, REINDEX_TRIGGERED
migrations: add audit_logs + webhook_outbox tables for both SQLite (001_create_streams_table.ts) and PostgreSQL (1774715200000_audit-and-webhook-outbox.ts)
tests: 25 tests across 9 suites covering atomic commit, rollback on stream/audit/webhook failure, idempotent upsert, invalid status transitions, decimal-string precision, and sequential transactions
Decimal-string amounts are preserved as TEXT throughout never converted to numbers ensuring full Stellar precision (7 dp) across the chain -> DB -> API boundary.