Repository navigation
fix(doctor): read Amp and Goose MCP registrations instead of calling them unreadable - #1975
Merged
Merged
Conversation
…them unreadable The doctor only had readers for json, claude-cli, toml, zed-context-servers, opencode-mcp and crush-mcp, so the Amp (amp-settings) and Goose (goose-yaml) targets came back as unreadable even when egc init had registered the servers. Add a reader for each, plus a test that fails if any registration target format lacks a doctor reader. Signed-off-by: Felipe Marzochi <fmarzochi@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
egc doctorreported the Amp and Goose MCP registrations asunreadableeven whenegc inithad registered the servers. The MCP section only had readers forjson,claude-cli,toml,zed-context-servers,opencode-mcpandcrush-mcp, so theamp-settingsandgoose-yamltarget formats fell through to "no reader for the format".Change
amp-settings(JSON under theamp.mcpServerskey the registrar writes).goose-yaml(the YAMLextensionslist, each with a stdio transport).Test
node --test tests/lib/doctor-mcp-readers.test.jspasses all four cases: the two readers, an empty-key case, and the every-format-has-a-reader guard.Summary by cubic
egc doctornow reads Amp and Goose MCP registrations instead of reporting them as unreadable whenegc inithad registered the servers.amp-settingsformat, reading servers from theamp.mcpServerskey.goose-yamlformat, reading servers from theextensionslist.Written for commit 8417153. Summary will update on new commits.