Skip to content

If a subcommand does not set a version, use the root command's version#176

Merged
FollowTheProcess merged 1 commit intomainfrom
feat/show-root-version
Oct 23, 2025
Merged

If a subcommand does not set a version, use the root command's version#176
FollowTheProcess merged 1 commit intomainfrom
feat/show-root-version

Conversation

@FollowTheProcess
Copy link
Owner

@FollowTheProcess FollowTheProcess commented Oct 23, 2025

Summary

If a Command does not define it's own cli.Version, fallback to using the root command's version which is probably what will happen 99% of the time because who versions subcommands?

@FollowTheProcess FollowTheProcess added the feature New feature or request label Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.50%. Comparing base (aa45774) to head (cc50294).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
command.go 69.23% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   90.65%   91.50%   +0.85%     
==========================================
  Files           5        5              
  Lines        1627     1260     -367     
==========================================
- Hits         1475     1153     -322     
+ Misses        106       61      -45     
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FollowTheProcess FollowTheProcess merged commit 87ee10b into main Oct 23, 2025
11 of 12 checks passed
@FollowTheProcess FollowTheProcess deleted the feat/show-root-version branch October 23, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant