Skip to content

Migrate internal/flag to the new parse/format mechanisms#180

Merged
FollowTheProcess merged 4 commits intomainfrom
refactor/flag-new-packages
Nov 9, 2025
Merged

Migrate internal/flag to the new parse/format mechanisms#180
FollowTheProcess merged 4 commits intomainfrom
refactor/flag-new-packages

Conversation

@FollowTheProcess
Copy link
Owner

  • Add shared parse errors to flag
  • Use parse and format in flag
  • Tweak the type names definitions
  • Migrate flag to the new parse/format mechanisms

Summary

@FollowTheProcess FollowTheProcess added the refactoring Refactoring label Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 97.64706% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.70%. Comparing base (72a4930) to head (cc50846).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/format/format.go 87.50% 1 Missing and 1 partial ⚠️
internal/parse/parse.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   86.32%   85.70%   -0.63%     
==========================================
  Files           7        7              
  Lines        1514     1476      -38     
==========================================
- Hits         1307     1265      -42     
- Misses        145      148       +3     
- Partials       62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FollowTheProcess FollowTheProcess merged commit 934263f into main Nov 9, 2025
12 checks passed
@FollowTheProcess FollowTheProcess deleted the refactor/flag-new-packages branch November 9, 2025 12:56
FollowTheProcess added a commit that referenced this pull request Dec 3, 2025
* Add shared parse errors to flag

* Use parse and format in flag

* Tweak the type names definitions

* Migrate flag to the new parse/format mechanisms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant