Skip to content

[TR_127] Add Help page with subpages#39

Open
dschrimm wants to merge 18 commits intoFoodIsLifeBGP:masterfrom
dschrimm:master
Open

[TR_127] Add Help page with subpages#39
dschrimm wants to merge 18 commits intoFoodIsLifeBGP:masterfrom
dschrimm:master

Conversation

@dschrimm
Copy link
Copy Markdown

@dschrimm dschrimm commented Mar 14, 2020

While there is still work remaining, I hope this will be a useful start and provide guidance for whoever picks up the rest of this task.

Update

  • Help screen
  • FAQ screen
  • Contact Us screen
  • new ContentHeader component
  • Updated to new Figma designs (04/01/20)
  • Some parts of the layouts look broken, but are actually styled correctly. The styling will look correct once other components are updated (e.g. TopNavBar/Header and Icons)

help-page-preview


ContentHeader Preview

Small

content-header_small

Large

content-header_large

@jacksonrya jacksonrya changed the title Add Help page with subpages [TR_127] Add Help page with subpages Mar 29, 2020
Copy link
Copy Markdown
Contributor

@jacksonrya jacksonrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution and start to these pages. Since the hackathon, we've updated the UI a little bit. So besides a few comments for discussion/ changes, most of this review is a TO-DO list for the rest of the PR.

Take note that PRs shouldn't be created from your master. If you decide to continue contributing to this task, you should close this PR and open a new one with the changes transferred to a new branch.

Style Guide Update

Contact Screen
  • Restyle header/banner & update text
  • Create private, contact list item component
    • Check if list style is anywhere else in app
  • Add back button
FAQ Screen
  • Create object of FAQ questions to mimic data from an API call
  • Finish list item component
  • Update header
Help Screen
  • Update list item style
  • Update header text

Comment thread src/elements/LinkButton/LinkButton.styles.ts
Comment thread src/elements/Title/Title.styles.ts Outdated
Comment thread src/screens/ContactScreen/ContactScreen.tsx
Comment thread src/screens/ContactScreen/ContactScreen.tsx
Comment thread src/screens/ContactScreen/ContactScreen.tsx Outdated
@jacksonrya
Copy link
Copy Markdown
Contributor

Rebased March 31, 17:35

@jacksonrya jacksonrya changed the title [TR_127] Add Help page with subpages [TR_127] Add Help page with subpages - READY FOR REVIEW Apr 2, 2020
@jacksonrya jacksonrya dismissed their stale review April 17, 2020 22:01

This change request was from the hackathon contribution.

@jacksonrya jacksonrya changed the title [TR_127] Add Help page with subpages - READY FOR REVIEW [TR_127] Add Help page with subpages Apr 20, 2020
Comment thread src/screens/ContactScreen/ContactScreen.tsx
Comment thread src/screens/ContactScreen/ContactScreen.tsx
Comment thread src/screens/ContactScreen/ContactScreen.styles.ts
Comment thread src/elements/ContentHeader/ContentHeader.tsx
Comment thread src/screens/FaqScreen/FaqScreen.tsx
Comment thread src/screens/HelpScreen/HelpScreen.tsx
renburnett
renburnett previously approved these changes May 24, 2020
Copy link
Copy Markdown
Collaborator

@renburnett renburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks really nice! However before we close this PR I had a few questions that I'd like addressed.

@jacksonrya
Copy link
Copy Markdown
Contributor

@renburnett were the questions you had within the review comments you made?

@renburnett renburnett closed this May 29, 2020
@renburnett renburnett reopened this May 29, 2020
@renburnett
Copy link
Copy Markdown
Collaborator

@renburnett were the questions you had within the review comments you made?

@jacksonrya yup! all questions resolved thanks! ( sorry for delay in response )
:)

sagehen03 pushed a commit that referenced this pull request Jun 11, 2020
Copy link
Copy Markdown
Collaborator

@renburnett renburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabling this until prealpha +

@renburnett renburnett dismissed their stale review June 14, 2020 06:09

Tabling this until prealpha +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants