Docs for 0.4.0: audit of README, CONFORMANCE, PUBLISHING, docstrings, CLI help - #102
Merged
Merged
Conversation
… CLI help
Every README Python example and shell command was run against the
release candidate, every backticked API name resolved against the
package, and every in-page link checked. Fixed:
- README: the quick-start and JSON output showed the wrong lines (14/22
for findings on line 24) and one diagnostic of two; Scope said no file
is read beyond the document (0.4.0 reads amended originals,
attachments, and a template's files); the deprecation note now lists
the deprecated importer type aliases; the __all__ trim is marked
"Changed in 0.4.0"; slugify_identifier(value, …) and the keyword-only
depth= of the quote readers; public names documented nowhere
(SectionIndexEntry, ListItem, Amends, Representative, CustomField,
AssemblyResult, AssemblyError) now are; Form.as_dict()'s fields.
- CONFORMANCE: 85 of 113 rules (was 84: raw-html), the harness counts
(234 passed, 39 skipped), answer rules point at Template.form, not the
deprecated assemble.
- PUBLISHING: the project has been on PyPI since 0.1.0.
- Docstrings: no references to the internal quote_content or the
deprecated assemble; HeadingSpan names {when=...}; legaldown and
legaldown.validator module docstrings say what each holds.
- CLI help: validate's streams and exit statuses, assemble refusing a
template with template-rule errors, -i and --save-answers precisely.
- pyproject description mentions template assembly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013WmBAc5T7UCKVdpUmg9qxz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a full documentation audit of the 0.4.0 release candidate. There are no code changes beyond docstrings and the CLI's help text.
How it was checked
A runner (kept outside the repo) does the following:
legaldown …shell line, and diffs the README's sample output against the real output.#anchorlink resolves.__all__lists (legaldown,.validator,.grammar,.syntax) is documented, and that every backticked API name resolves.Before the fixes it found 28 problems; after them, 0.
Fixed
README
__all__trim is labelled "Changed in 0.4.0".slugify_identifier(value, …), anddepth=is keyword-only on the quote readers.SectionIndexEntry,ListItem,Amends,Representative,CustomField,AssemblyResult,AssemblyError. TheForm.as_dict()field list is complete.assemble.CONFORMANCE.md
raw-htmlwas never counted.Template.form, not the deprecatedassemble. A self-contradicting sentence in the Assembly section is fixed..github/PUBLISHING.md
Docstrings
quote_blocksno longer refers to the internalquote_content.HeadingSpannames{when=...}, not a non-existent{if:}marker.AssemblyResultandQuestion.from_textno longer refer to the deprecatedassemble.legaldownandlegaldown.validatormodule docstrings now say what each module holds.CLI help
validatenow states its output streams and exit statuses.assemblestates that a template with errors in the template rules is refused.-iand--save-answershelp texts are now precise.-iandquestions.pyproject.toml: the description now mentions template assembly.
Verification
ruffis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_013WmBAc5T7UCKVdpUmg9qxz
Generated by Claude Code