Add meta to error in check - #14
Open
legodude17 wants to merge 3 commits into
Open
legodude17 wants to merge 3 commits into
legodude17 wants to merge 3 commits into
Conversation
kenany
approved these changes
Jan 18, 2017
kenany
requested changes
Jan 18, 2017
kenany
left a comment
kenany
left a comment
Collaborator
There was a problem hiding this comment.
I'd love to see the tests updated accordingly. Also, there are a few other places where we return errors; they should be updated as well.
Author
|
@kenany finished updating the tests and adding all the metadata. Rereview? |
Collaborator
|
@legodude17 How come I don't see any changes to |
Author
|
@kenany Ok then... I don't know, I guess I will do that again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add some of the metadata in
checkto the error object before giving it to the callback.