fix auto-redeem failures surfacing for ops#18
Open
mooncitydev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, was reading the relayer auto-redeem path and noticed a few places errors were effectively swallowed.
execute()caught failures fromprocessAutoRedeem(), logged them, then returned without rethrowing. The loop inmain.tsonly sees real failures when the promise rejects, so a broken run could look like a quiet success from outside (metrics, k8s exit code if someone wraps this differently, etc.). Now the error propagates after logging.findPendingRedeems()returned an empty list on any prisma error, which looks the same as "nothing to claim" and can hide a dead database or bad query. Db errors now bubble up.For batches, one failing
processBatchused to log and continue, so you could burn through the loop and still finish the tick without a top-level failure even if half the redeems never got submitted. It now collects failures and throws anAggregateErrorwith per-batch context so you get one loud failure with counts.cheers