security: harden external PR replay workflow with actor gate and pre-scan (#144)#170
Merged
Merged
Conversation
The content pre-scan added in #144 only logged a warning, so a fork PR editing .github/workflows/*, .githooks/*, or scripts/* still got force- pushed into a trusted branch and executed on the self-hosted runner unattended. Make it a required checkpoint: fail the job unless the maintainer explicitly re-runs with acknowledge_critical_files: true after reviewing the diff. Also fix word-splitting on filenames in the scan loop. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the external PR replay workflow (
approve-external-pr.yml) by introducing in-workflow actor authorization checks and a PR content security pre-scan to prevent unauthorized execution and flag critical CI modifications on self-hosted runners.Fixes #144
Changes
Verify maintainer authorization) inapprove-external-pr.ymlto verify actor permissions against@Daliysor admin/write collaborator status.Run security pre-scan on PR files) inapprove-external-pr.ymlto inspect modified files and alert maintainers if critical CI files (.github/workflows/*,.githooks/*,scripts/*) are touched.CHANGELOG.mdunder[Unreleased]/Security.Validation
PYTHONDONTWRITEBYTECODE=1 scripts/prepush-validate.sh --static-onlypassed.