Repository navigation
Speed up the "find the app" search - #10
Merged
Merged
Conversation
A plain recursive grep read every byte of every file in one process: on a Mac with 63 GB under /Applications and Application Support, including a 10 GB VM disk image, it ran for well over 10 minutes. The macOS and Linux commands now skip files over 1 GB and run 8 greps in parallel via find | xargs -P (about 2 minutes on the same Mac, same results); the Windows command skips files over 1 GB too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The app search in Find the app on the client used
grep -r, which reads every byte of every file in a single process. On a real Mac (63 GB under/Applicationsand~/Library/Application Support, including a 10 GB VM disk image) it ran for well over 10 minutes.find … -type f -size -1024M -print0 | xargs -0 -n 200 -P 8 grep -l --binary-files=text -F '<name>'. This skips files over 1 GB and runs 8 greps at a time.Where-Object Length -lt 1GBbeforeSelect-String.App frameworks of several hundred MB, such as browser frameworks, Electron
app.asarfiles and Qt WebEngine, are still searched.How was it tested?
terraform test(not affected)Checklist
CHANGELOG.md(Unreleased) updated where users would notice🤖 Generated with Claude Code