Repository navigation
Stop waiting when a device push fails, and show its errors - #4
Merged
Merged
Conversation
SCM ends a device push the firewall rejects as PUSHFAIL, never FIN, so push_and_wait waited out its 30-minute timeout (in the GUI too) instead of reporting the failure. Jobs now count as done on any final status, or once they have an end time and a result, and a failure logs the device's error lines rather than raw job JSON. Troubleshooting now covers the usual cause: a rule referencing an object someone created in SCM but hasn't pushed, which the app's own push can't include. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
When a firewall rejects a push, SCM ends the device's job as
PUSHFAIL, neverFIN.push_and_waitonly treatedFINas finished, so it waited until its 30-minute timeout, in the GUI too, instead of reporting the failure.FIN,PUSHFAIL,PUSHABORT,PUSHSUCC), or once it has an end time and a result.Error: Failed to find address '…', instead of the raw job JSON.How was it tested?
uv run python -m unittest discover tests: new tests replay a realPUSHFAILjob sequence (anonymised), a successful push, and jobs that are still running.terraform test(not affected)Checklist
CHANGELOG.md(Unreleased) updated where users would notice🤖 Generated with Claude Code