Repository navigation
Fix: Reject submit-signed from different session wallet - #294
Merged
karagozemin merged 6 commits intoOct 1, 2026
Merged
karagozemin merged 6 commits into
karagozemin merged 6 commits into
Conversation
|
@Olasunkanmi975 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@karagozemin please kindly review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201
Description
This PR addresses the security vulnerability outlined in #201, where login sessions, cookies, and the submit route evaluated the wallet independently. It enforces a strict auth-to-payment integration by ensuring a session opened by one account cannot authorize another account's payment.
Changes Made
AuthSessioninsession.tsto directly store the authenticated public key during the login challenge./api/auth/refreshto verify the state of the session wallet. If the wallet is revoked or if the account is temporarily locked, the refresh token is invalidated./api/stellar/submit-signedto securely verify the transaction's source account and its cryptographic signer against the active session's public key. Returns403on mismatch.verifySignedXdrSignerinclient.tsto cryptographically verify XDR signatures using the@stellar/stellar-sdk.