Skip to content

fix: show time until the event (not the reminder) in the save countdown #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MiMoHo wants to merge 1 commit into from
Closed

fix: show time until the event (not the reminder) in the save countdown #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Updated holiday data

### Fixed
- Fixed the save-event countdown to show time until the event instead of time until the reminder ([#1073])
- Fixed event text readability on colored backgrounds ([#1065])
- Fixed invisible current time indicator in weekly view ([#99])
- Fixed stuck zoom level in weekly view on some devices ([#621])
Expand Down Expand Up @@ -252,6 +253,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#1019]: https://github.com/FossifyOrg/Calendar/issues/1019
[#1024]: https://github.com/FossifyOrg/Calendar/issues/1024
[#1065]: https://github.com/FossifyOrg/Calendar/issues/1065
[#1073]: https://github.com/FossifyOrg/Calendar/issues/1073
[#1157]: https://github.com/FossifyOrg/Calendar/issues/1157

[Unreleased]: https://github.com/FossifyOrg/Calendar/compare/1.10.3...HEAD
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/kotlin/org/fossify/calendar/extensions/Context.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ fun Context.scheduleEventIn(notifyAtMillis: Long, event: Event, showToasts: Bool

val newNotifyAtMillis = notifyAtMillis + 1000
if (showToasts) {
val secondsTillNotification = (newNotifyAtMillis - now) / 1000
val secondsTillEvent = event.getEventStartTS() - getNowSeconds()
val msg = String.format(
getString(org.fossify.commons.R.string.time_remaining),
formatSecondsToTimeString(secondsTillNotification.toInt())
formatSecondsToTimeString(secondsTillEvent.toInt())
)
toast(msg)
}
Expand Down
Loading