Skip to content

feat: call directly instead of launching dialpad#563

Merged
naveensingh merged 2 commits into
mainfrom
naveensingh/direct-call
Oct 23, 2025
Merged

feat: call directly instead of launching dialpad#563
naveensingh merged 2 commits into
mainfrom
naveensingh/direct-call

Conversation

@naveensingh
Copy link
Copy Markdown
Member

@naveensingh naveensingh commented Oct 16, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Updated the dialNumber() method to use ACTION_CALL instead of ACTION_DIAL when CALL_PHONE permission is available.
  • Added CALL_PHONE permission to the manifest. Unlike other apps (see this), declaring this permission is not required because the SMS role grants the whole Phone permission set by default as per this code, but I added it anyway to avoid issues due to any OEM-specific changes and to not rely on a "side-effect".

Tests performed

  • Calling

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh merged commit f3408f1 into main Oct 23, 2025
5 checks passed
@naveensingh naveensingh deleted the naveensingh/direct-call branch October 23, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call from messages displays number instead of dialling immediately

1 participant