Skip to content

fix: guard takePersistableUriPermission against SecurityException when storing alarm sound #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MiMoHo wants to merge 1 commit into from
+6 −1
Closed

fix: guard takePersistableUriPermission against SecurityException when storing alarm sound #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion commons/src/main/kotlin/org/fossify/commons/extensions/Context.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,12 @@ fun Context.storeNewYourAlarmSound(resultData: Intent): AlarmSound {
baseConfig.yourAlarmSounds = Gson().toJson(yourAlarmSounds)

val takeFlags = Intent.FLAG_GRANT_READ_URI_PERMISSION
contentResolver.takePersistableUriPermission(uri, takeFlags)
try {
contentResolver.takePersistableUriPermission(uri, takeFlags)
} catch (_: SecurityException) {
// some file managers return a content uri without a persistable
// permission grant, which would otherwise crash the app
}

return newAlarmSound
}
Expand Down
Loading