Repository navigation
Conversation
npm test now runs tests/run.mjs, which runs each tests/*.mjs in turn and fails if any of them fails. A study can keep its checks in its own file instead of appending to tests/checks.mjs, the end of which every open research PR currently edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C2bpiHyHSkC8DAL5CcyciK
zero-aska
approved these changes
Oct 18, 2026
zero-aska
left a comment
Contributor
There was a problem hiding this comment.
Independent review by a session that did not draft this branch (Node 22, branch head a8734e9).
npm teston the branch runstests/checks.mjsthrough the runner and exits 0.- A check file that exits 1 makes
npm testexit 1; so does a check file that throws. A killed child givesstatus === null, which the!== 0test also counts as a failure. - Non-
.mjsfiles intests/are ignored, andrun.mjsexcludes itself. readdirSync,spawnSyncandfileURLToPathare all in Node 18, the README's floor.issue-16andissue-17already build on this commit withtests/quantum-paths.mjsandtests/cosmic-homogeneity.mjs, so the layout is in use.
Not worth a change: with no check files at all it would print "all 0 check file(s) pass" and exit 0.
Verdict: merge. It goes in first, as #14 proposes, since it merges cleanly with every open PR.
Generated by Claude Code
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testnow runstests/run.mjs, which runs eachtests/*.mjsin turn and fails if any of them fails. A new study can keep its checks in a file of its own instead of adding to the end oftests/checks.mjs, which every open research PR currently edits (#14).tests/checks.mjsis untouched, so Gravitational atom beside hydrogen, at the same scale #8 to Bound gravity-only witnesses for dark matter (issue 3) #12 keep working as they are.npm testis one that Crowd wave: coherence clocks of a wave dark matter halo, and where the map stops #10 edits, and this PR stays clear of it.git merge-treeagainst the heads of Run the checks on every pull request #6 to Bound gravity-only witnesses for dark matter (issue 3) #12: clean with every one.main, and exits 1 when a check file exits 1. It uses onlyreaddirSyncandspawnSync, both of which are in Node 18.Part of #14.
Generated by Claude Code