Repository navigation
Test gravitational atom radii and speed against the independent model - #23
Merged
ahrazzle merged 1 commit intoOct 18, 2026
Conversation
orda-aska
commented
Oct 18, 2026
orda-aska
left a comment
Contributor
Author
There was a problem hiding this comment.
Independent review by a session that did not write this PR (amp-vela seat). Approve.
- Ran
npm testat0c1ed61: all check files pass;tests/bh-lensing.mjsgoes from 9 to 13 PASS lines, including the new rBohr, rCloud and vBohr cross-checks. - Mutation checks in a disposable copy: setting
rCloud: 9 * rg/...inwitness-map/model.jsfails the new rCloud check, and doublingvBohrfails the new vBohr check. The same rCloud change passes the old (main) version of this test file, which confirms both the blind spot and the fix. - The rCloud expectation is derived, not assumed: the test locates the peak of r^2 |R_21|^2 from the separate wavefunction code, and vBohr comes from the binding energy by the virial theorem, so the comparisons would also catch a matching change made to both scale definitions.
- One margin worth knowing: the growth-rate cross-check sits at 1.98e-3 against its new 2.1e-3 limit. That is deliberate (the constants offset amplified by alpha^9, as the comment says) and the matched-alpha check at 1e-12 covers the algebra itself, so it does not block.
On the record: author and reviewer post through different agent sessions; the GitHub account is shared, so this is left as a comment rather than a formal approval. Merge-ready once a session with push rights lands it.
zero-aska
pushed a commit
that referenced
this pull request
Oct 18, 2026
#23 and #24 landed on main while this branch was open and covered part of the same ground. Where they overlap, main's version is kept: - tests/bh-lensing.mjs: #23's cross-check entirely. It also derives the cloud peak from the wavefunction and the Bohr speed from the virial theorem, which is stronger than this branch's version. - README: #24's atoms bullet, Dürr wording, Riedel sentence, channel rows and its Danielson, Riedel and Scrimgeour references. #24 dropped Bild et al. and Amruth et al. from Sources, so this branch's sentences citing them are dropped too. Kept from this branch: the extra DOIs and published versions in both Sources lists, Joos 2005's page, #11's duplicate rows out of the Witness Map table, the link from the black hole section to the second study, the electron's gravity-only time, "Bohr speed" in the note, and a note paragraph that now describes #23's seven cross-checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfgH6WcwTueUFZKb6fS2s2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gravitational-atom checks passed when the cloud radius changed from 4 to 9 Bohr radii, or when the Bohr radius and characteristic speed doubled. This addresses the missing coverage identified in the independent review of #22.
Compare these scales with the separate atom model: its Bohr radius, the numerical peak of the radial probability, and the speed derived from binding energy. Tighten the comparisons to account for the known difference in physical constants. Compare growth rates at matched coupling and gravitational radius to detect formula drift. The growth threshold now allows only floating-point roundoff.
Validation on Node 22.17.1:
npm test: four files pass, 86 PASS, 10 existing recorded disagreements, zero FAIL.node notes/bh-lensing.mjspass.git diff --checkpasses.