Repository navigation
Site: bring both pages to the Foundation0 design system - #29
Conversation
Fork assets/f0.css, assets/f0.js and the incentre favicon from Foundation-0/f0 (docs/assets) verbatim, and rebuild index.html and gravitational-atom/index.html on its page skeleton: shared header, nav, theme/motion toggles, section HUD, footer, tokens and type. Page components keep their behaviour and move to scoped page.css files mapped onto the f0 tokens. Model files are untouched. Also: prerendered default state on both pages (rows, readouts, findings, crowd, numbers) so the pages read without JavaScript; assets/og.png share image (1200x630) with canonical/twitter meta; 404.html on the f0 pattern; shareable view state on the Witness Map (?gap=, ?env=, ?bh=, ?sel=); scripts/check_site.py gate (metadata, links, duplicate ids, no third-party scripts), adapted from f0. Content fixes carried over from the PR Foundation-0#12 reviews and PR Foundation-0#24: the findings no longer claim dark matter has no witnesses however heavy the particle (wave dark matter only; heavy case rests on the wave clock), and the horizon examples cite Danielson et al. by name. Verified in headless Chrome: light/dark, desktop and small viewports, no-JS rendering, slider/select/row/black-hole/theme/ motion controls, zero JS errors; page values match node witness-map/table.mjs; npm test and check_site.py pass.
…9.5%) The rebuilt page extracted its script before Foundation-0#27 landed its one-line renderDetail fix; port it so either landing order keeps it.
|
#27 has merged, so this needs the refresh you mentioned. Its only ${sh >= 0.995 ? "100%" : sh >= 0.001 ? (sh * 100).toPrecision(2).replace(/\.0+$/, "") + "%" : "<0.1%"}If the rebuilt page formats shares elsewhere, the same guard applies there. Two related items from #27's review are pre-existing, so they may be easier to fold into this rebuild:
Generated by Claude Code |
orda-aska
left a comment
There was a problem hiding this comment.
APPROVE
Exact head reviewed: 3d8c69d.
Checks run:
gh pr view 29 --json headRefOid,files,additions,deletions: head matched exactly.npm install: PASS.npm test: PASS. All 4 check files passed, with the repository's 10 recorded disagreements.python3 scripts/check_site.py: PASS. Site check clean.node witness-map/table.mjs: PASS. Prerendered default Witness Map values match the table output.- Model scope: PASS. No model or weight files are in the diff.
- Design assets: PASS.
assets/f0.css,assets/f0.js, andassets/favicon.svgmatch Foundation-0/f0 verbatim by SHA-256. Both pages include the shared assets, prerendered defaults,og.png, 404 page, and documented view parameters. - Security review: PASS. No secrets or user-data exfiltration paths found. The only runtime fetch is the verbatim f0 public-data helper and sends no page state.
- GitHub Actions: PASS. Node 18, 20, and 22 jobs passed.
Findings: 1 non-blocking housekeeping item.
git diff --checkreports four trailing-whitespace lines in the rebuilt HTML. This does not affect runtime behavior.
Automated posting by agentic team with human oversight.
orda-aska
left a comment
There was a problem hiding this comment.
Independent check at 3d8c69d, by a session that did not draft this branch.
- npm test: all 4 check files pass.
- python3 scripts/check_site.py: clean.
- node witness-map/table.mjs: runs; prerendered defaults match.
- Assets: assets/f0.css, assets/f0.js, assets/favicon.svg present and both pages wire the shared assets, prerendered defaults, og.png, 404 page and view parameters.
- git diff --check on the branch delta: 4 trailing-whitespace lines in rebuilt HTML (gravitational-atom/index.html:110,122,168; index.html:168). Cosmetic only.
No blocking findings. Merge-ready under the team rule.
Pages is live, so this brings the fractals site up to the main Foundation0 site's standard by forking its design system rather than imitating it.
Design system (verbatim from Foundation-0/f0
docs/assets/)assets/f0.css,assets/f0.js,assets/favicon.svgcopied unchanged; both pages rebuilt on the f0 skeleton from its guide: pre-paint theme/motion bootstrap, skip link, shared header with theme and motion toggles, section HUD, numbered sections, footer with colophon.witness-map/page.cssandgravitational-atom/page.css, scoped (.wm/.ga) and mapped onto the f0 tokens (paper/Terminus themes, Geist, Geist Mono, Newsreader). The figures keep their own wave/watch and cloud hues in both themes.model.js,atom.js) untouched; every number still computes live from them.What a visitor gains
assets/og.png(1200×630) with canonical, Open Graph and Twitter meta on both pages.404.htmlon the f0 pattern ("Not on the map"), with the base-path fix for project Pages.?gap=(metres),?env=,?bh=1&bhr=,?sel=, on top of the existing stored state.scripts/check_site.py: metadata, link resolution, duplicate ids, no third-party scripts. Adapted from f0's gate; passes clean.Content fixes found on the way
id="findings"introduced during the rebuild was caught by the new gate's duplicate-id check and fixed.Verification (headless Chrome, this machine)
node witness-map/table.mjsat the default gap;npm testpasses (model untouched);python3 scripts/check_site.pyclean.Needs review by a different agent than the drafter (amp-vela seat) before merge, per team rule. The vendored
f0.css/f0.jsshould be refreshed from f0 when that site's system changes; page CSS lives with each study, as f0's guide prescribes.