Repository navigation
Add ovarian HGSOC treatment-sequence parameter ledger - #5
Merged
Merged
Conversation
Introduce a machine-readable treatment-sequence parameter ledger under data/clinical/, extending the project-asma PR #47 registry citation shape with quantitative rows (KNOWN, CONJECTURE, MISSING). Include schema validation, offline pytest coverage, CI hook, and a pinned script with an optional Crossref DOI title/author verification step. Co-authored-by: Orda <orda@askaconsult.com>
Restrict KNOWN to TCGA values read from PMC3163504; downgrade trial and meta-analysis figures to CONJECTURE (abstract only) or MISSING when full text is paywalled or the abstract lacks the quantity. Correct CA-125 and HRD rows and document verification locators. Co-authored-by: Orda <orda@askaconsult.com>
ahrazzle
requested changes
Nov 5, 2026
ahrazzle
left a comment
Member
There was a problem hiding this comment.
REQUEST CHANGES at 5a293f6. The ledger values check out against their sources, but the required test check is red.
Blocker
- The new test file fails at collection. It does
from scripts.validate_ovarian_parameter_ledger import ..., but nothing puts the repo root on the import path: there's noscripts/__init__.py, no conftest and no pytestpythonpath. The workflow setsPYTHONPATH=.only for the validator step.- CI run 42059696760:
E ModuleNotFoundError: No module named 'scripts',1 error in 1.46s. - Clean venv,
pip install -e ".[dev]", thenpytest -m "not network": the same collection error. - With
PYTHONPATH=.: 116 passed, 1 deselected. - Fix: add
pythonpath = ["."]to the pytest config, or makescriptsimportable.
- CI run 42059696760:
Should fix (a source claim that's wrong)
- P005's locators are wrong. "Homologous recombination is defective in about half of tumors" is in the Abstract, not the Results, and the second quote is in the Results, not the Discussion (checked in the NCBI BioC full text). The 0.5 value itself is right.
Verified
- Validator: passes with 22 entries (KNOWN 4, CONJECTURE 6, MISSING 12).
--check-doisfinds 11 unique DOIs, all ok. - KNOWN rows: P002 0.09, P003 0.08, P004 0.13 and P005 0.5 match the TCGA full text.
- CONJECTURE rows: P001, P009, P010, P011, P021 and P022 match their PubMed abstracts word for word and are labelled abstract-only.
- MISSING rows: all 12 have null value and range, and the reasons given are accurate.
- Mutations: the validator catches a dropped required field and a value on a MISSING row, and
--check-doiscatches a corrupted DOI.
Notes (non-blocking)
- Values aren't pinned. Changing P002 from 0.09 to 0.19 passes both the validator and the tests (exit 0). A test pinning the KNOWN values would catch this.
- Schema not enforced. The JSON schema file is never loaded; the validator only prints its path.
- project-asma claim. The ledger says it follows the project-asma registry pattern, but no
registries/*.jsonfile there uses KNOWN/CONJECTURE/MISSING labels, and the ledger has no pmid,source_idsorstatusfields. Either reword that claim or align the format.
Set pytest pythonpath to the repo root so CI can import scripts without PYTHONPATH. Correct P005 PMC section locators and add regression tests for verified KNOWN numeric values P002–P005. Co-authored-by: Orda <orda@askaconsult.com>
ahrazzle
approved these changes
Nov 5, 2026
ahrazzle
left a comment
Member
There was a problem hiding this comment.
APPROVE at e11ba89. All three findings are fixed and verified.
- Import path:
pythonpath = ["."]is set. In a clean venv,pip install -e ".[dev]"thenpytest -q -m "not network"gives 117 passed, 1 deselected with noPYTHONPATH. CItestis green (run 42060975424). - P005 locators: they now read Abstract ("…defective in about half of tumors") and Results ("…approximately half of HGS-OvCa"), matching the PMC3163504 full text.
- Value pinning: I re-ran the earlier mutation, changing P002 from 0.09 to 0.19.
test_known_row_values_pinned_to_verified_numbersnow FAILS (1 failed, 116 passed), so the pin works.
MERGEABLE against main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cited ovarian HGSOC / treatment-sequence parameter ledger under
data/clinical/, with schema, README, offline tests, CI, andscripts/validate_ovarian_parameter_ledger.py(optional--check-dois).Head SHA:
e11ba89655af22bba9f893e008fd728d920adc7eReview fixes (grk-proof)
pythonpath = ["."]in[tool.pytest.ini_options]fixesModuleNotFoundError: scriptsduring collection (was failing run 42059696760).test_known_row_values_pinned_to_verified_numberslocks P002–P005 values.Extended structure
docs/project-asma-integration.md).data/clinical/— quantitative extension alongside provenance-annotated clinical inputs.Branch on main; schema compatible with PR #47 consumers.
Label counts (after full-text bar pass)
Rule applied: KNOWN only when the value was read from open full text (PMC3163504 for TCGA). Paywalled trials/meta-analyses → CONJECTURE if PubMed abstract states the quantity, else MISSING.
Per-row verification
Crossref DOI check
Validation
pytest -q -m "not network": 117 passed, 1 deselected (ledger tests include KNOWN value pins)testjob: success on run 42060975424Boundaries
Public sources only; not medical advice (README disclaimer). Do not merge without review.
AI disclosure
Re-verification and review fixes by Cursor Cloud Agent (Composer) with PubMed abstracts and TCGA open full text (PMC3163504). Builds on project-asma PR #47 and virtual-human PR #3 integration docs.