Skip to content

Fix code coverage #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FourierTransformer merged 2 commits into from
Oct 14, 2025
Merged

Fix code coverage #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed67a58
Update test-and-coverage.yml
FourierTransformer Oct 14, 2025
7f6173a
Removing commented out tests
FourierTransformer Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ jobs:
- name: Report test coverage
if: success()
continue-on-error: true
run: luacov-coveralls -e .luarocks
run: luacov-coveralls -e lua_install
env:
COVERALLS_REPO_TOKEN: ${{ github.token }}
18 changes: 0 additions & 18 deletions spec/parse_encode_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,24 +115,6 @@ describe("csv encode without quotes", function()
end
end)

--[[ This breaks simple_crlf.
describe("csv encode with missing keys", function()
for _, value in ipairs(files) do
it("should handle " .. value, function()
local jsonFile = loadFile("spec/json/" .. value .. ".json")
local jsonDecode = cjson.decode(jsonFile)
local reEncoded = ftcsv.parse(ftcsv.encode(
jsonDecode, ",", {
fieldsToKeep = {"a", "b", "c", "d"},
allowMissingKeys = true,
}
), ",", {loadFromString=true})
assert.are.same(jsonDecode, reEncoded)
end)
end
end)
--]]

describe("csv encode with missing keys", function()
it("should handle missing_keys", function()
local jsonFile = loadFile("spec/json/missing_keys.json")
Expand Down