Skip to content

spring Cleanup on Destroyed ( when not finished ) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RiseBit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

spring Cleanup on Destroyed ( when not finished ) #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions spr.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ end
local springStates_other: {[Instance]: {[string]: any}} = {} -- {[instance] = {[property] = spring}
local springStates_render: {[Instance]: {[string]: any}} = {} -- {[instance] = {[property] = spring}
local completedCallbacks: {[Instance]: {()->()}} = {}
local destroyingConnections: {[Instance]: RBXScriptConnection} = {}

local function processSprings(springStates: typeof(springStates_other), dt: number)
for instance, state in springStates do
Expand Down Expand Up @@ -767,6 +768,15 @@ function spr.target(instance: Instance, dampingRatio: number, frequency: number,
if not state then
state = {}
targetRecord[instance] = state

if not destroyingConnections[instance] then
destroyingConnections[instance] = instance.Destroying:Once(function()
springStates_other[instance] = nil
springStates_render[instance] = nil
completedCallbacks[instance] = nil
destroyingConnections[instance] = nil
end)
end
end

for propName, propTarget in properties do
Expand Down Expand Up @@ -801,6 +811,15 @@ function spr.target(instance: Instance, dampingRatio: number, frequency: number,

if not next(state) then
targetRecord[instance] = nil

local otherRecord = if targetRecord == springStates_render then springStates_other else springStates_render
if not otherRecord[instance] then
local conn = destroyingConnections[instance]
if conn then
conn:Disconnect()
destroyingConnections[instance] = nil
end
end
end
end

Expand Down