Implement dummy variables, fix variable null value handling, and consider angles as numbers - #58
Merged
Merged
Conversation
FramePerfection
commented
Jul 18, 2026
FramePerfection
commented
Owner
- resolves Dummy variables are not implemented #57
- fixes a crash stemming from null values in binary math operation variables
- angle variables are now considered as number variables so that binary math can be performed on them
hugou74130
approved these changes
Jul 18, 2026
hugou74130
left a comment
hugou74130
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally works perfectly.
Collaborator
There was a problem hiding this comment.
Small cleanup request: numDummies is unused now it was only referenced by the commented-out implementation this PR replaces. Could you drop it? Otherwise it stays as an assigned-but-never-used field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.