Repository navigation
fix(branding): repair malformed Frameropia PNG and Windows ICO - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The PNG and ICO uploaded for v0.0.3 were not byte-identical to the local validated originals. Binary data was inadvertently altered when copied into base64 strings. The resulting Git object SHAs did not match the source files, explaining corrupted logos.
Fix
Replace
dist/frameropia-logo.pnganddist/frameropia.icousing exact byte-verified base64 blobs. Validation:c21f9b804fc6364c454a393e21428f5f79395badc21f9b804fc6364c454a393e21428f5f79395bad1b87ff356fabf6c0f73d110f15d1249975fabb301b87ff356fabf6c0f73d110f15d1249975fabb30The PNG is a valid transparent 128x128 image; the ICO has a PNG-based 128x128 icon entry and has been decoded successfully locally. No game code, settings, or version changes.
Release impact
The initial v0.0.3 release workflow may already be running against a commit that contains the corrupted binaries. Do not claim its archive is fixed without a new build from this corrected commit. Need verify/refurbish the v0.0.3 published archive if it exists.