feat: move Kaorios to system paths and upload module test artifacts#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the Kaorios Toolbox payload is placed inside the generated module (moving from /product-scoped paths to /system-scoped paths) and enhances the CI feature test workflow to retain the produced module ZIPs as downloadable artifacts.
Changes:
- Update module creation to install Kaorios Toolbox APK and permissions into
system/priv-appandsystem/etc/permissionsinstead ofsystem/product/.... - In the feature test workflow, copy each generated module ZIP into the per-test-case results folder with a stable, versioned filename.
- Upload those per-test-case module ZIPs as GitHub Actions artifacts (with retention configured).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/core/module.sh |
Moves Kaorios Toolbox APK + permission allowlist destinations from system/product/... to system/... paths inside the module output. |
.github/workflows/feature-test-suite.yml |
Captures per-feature generated module ZIPs into test-results/... and uploads them as artifacts for inspection/debugging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.