use black text in StyleEditor epxlicitly #1684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Karry, I can provide a commit to use the palette colors of the style (Universal). Are you agreed ? Or you can have a look on the commit janbar@9e0ef87 |
Collaborator
Author
|
Thanks, I will look on it :-) |
Collaborator
Author
|
It would be nice also adjust color of highlighted keywords to keep some level of contrast... |
Karry
force-pushed
the
style-editor-explicit-color
branch
from
9afebd7 to
25ba190
Compare
Collaborator
Author
|
@janbar , your change is more complete (with style of the buttons), it looks good with dark theme. We may merge it as it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are using while text background, text is unreadable with dark system palette (using bright texts).
So, using black color explicitly makes it readable.