Skip to content

feat: honor --source/--tag in he talk and ka.chat - #13

Closed
Frankie-Xu wants to merge 1 commit into
mainfrom
cursor/talk-scoped-chat-bd8a
Closed

Frankie-Xu wants to merge 1 commit into
mainfrom
cursor/talk-scoped-chat-bd8a

Conversation

@Frankie-Xu

Copy link
Copy Markdown
Owner

Summary

  • Forward keyword-only source_ids / tags from AutoGraph.chat and AutoHypergraph.chat to search_nodes / search_edges.
  • base.chat accepts the same kwargs and only passes a name if inspect.signature(type(self).search) contains it.
  • he talk gains repeatable --source / --tag with the search inspect-guard against type(ka).chat (“scoped chat” / “no source ledger”). chat_loop keeps the same scope on every turn.
  • Document Scoped chat in talk.md and ka.chat(..., source_ids=..., tags=...) in search-and-chat.md (EN + ZH).

Closes yifanfeng97#160

Out of scope

  • MCP ask / search scope parameters
  • Changing search() semantics or the ledger
  • Fake filtering on types without a ledger
  • OntoSight chat_callback

Test plan

  • uv run pytest tests/cli/test_talk.py tests/types/test_graph_chat_scope.py tests/types/test_document.py tests/types/test_set_provenance.py -q
  • ruff check hyperextract and ruff format --check hyperextract
Open in Web Open in Cursor 

Co-authored-by: Frankie-Xu <Frankie-Xu@users.noreply.github.com>
@Frankie-Xu

Copy link
Copy Markdown
Owner Author

Opened on the fork by mistake. Review is at yifanfeng97#161 — closing this.

@Frankie-Xu Frankie-Xu closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: forward source/tag scope through he talk and ka.chat

1 participant