fix: forward source/tag scope through Cog_RAG.chat - #19
Closed
Frankie-Xu wants to merge 1 commit into
Closed
Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
Co-authored-by: Frankie-Xu <Frankie-Xu@users.noreply.github.com>
Owner
Author
|
Opened against the fork by mistake. Review PR: yifanfeng97#171 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cog_RAG.searchalready forwardssource_ids/tags.Cog_RAG.chatcallsself.search(...)without those kwargs.#161is the AutoType /he talkpath; amethod/cog_raginstance uses this override.Proposal
Add keyword-only
source_idsandtagsonCog_RAG.chatand pass them through toself.search.Closes yifanfeng97#170
Out of scope
graph_rag.py