fix: validate document templates require output.fields - #20
Closed
Frankie-Xu wants to merge 1 commit into
Closed
Frankie-Xu wants to merge 1 commit into
Frankie-Xu wants to merge 1 commit into
Conversation
Co-authored-by: Frankie-Xu <Frankie-Xu@users.noreply.github.com>
Owner
Author
|
Opened against the fork by mistake. Review PR: yifanfeng97#173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RECORD_TYPESis{model, list, set}.he template validatenever checks the output shape oftype: document. A document YAML that copies a graphoutput.entities/output.relationsblock passes.general/base_documentalready writes placeholderoutput.fieldsby hand.Proposal
Add
"document"toRECORD_TYPESso HE-T002 requiresoutput.fields._check_record_identifiersstill requiresitem_idonly forset. HE-T008 field-count warnings may apply to document templates.Closes yifanfeng97#172
Out of scope
base_document.yamlsemantics