fixes for PHP 7.3. Tested on running system.#73
Open
leonhedding wants to merge 7 commits intoFreePBX-ContributedModules:release/14.0from
Open
fixes for PHP 7.3. Tested on running system.#73leonhedding wants to merge 7 commits intoFreePBX-ContributedModules:release/14.0from
leonhedding wants to merge 7 commits intoFreePBX-ContributedModules:release/14.0from
Conversation
added 7 commits
February 11, 2021 13:23
found some additional variables that needed to be fixed for voicemail that were missed before.
Update functions.inc
|
I know this PR was intended for FreePBX 15 with PHP 7.3, but wanted to point out, in case others are hoping, that it will not work for FreePBX 16 with php 7.4. Install fails with |
JohnyVLive
approved these changes
Mar 14, 2023
|
Unfortunate to see this hasn't been merged yet... Also, any chance to get support for FreePBX v16 (or even v17) and PHP 7.4? I'm running into the same issue @lgaetz mentioned above on FreePBX v16, PHP 7.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unaware that the code did not work with PHP 7.3. The rest of FreePBX 15.x was running fine with PHP 7.3 so I went with that. I then found that this code did not work. I needed to fix various warnings generated with deprecated syntax. No new features.