fix foreign key creation from module.xml#194
Open
miken32 wants to merge 3 commits intoFreePBX:release/17.0from
Open
fix foreign key creation from module.xml#194miken32 wants to merge 3 commits intoFreePBX:release/17.0from
miken32 wants to merge 3 commits intoFreePBX:release/17.0from
Conversation
Contributor
Author
|
@kguptasangoma can this PR get reviewed please? We are updating a module to use XML database schema but have had to put it on hold due to this bug. Thanks. |
Contributor
Author
|
@jissphilip ? Anyone? |
Member
|
Hi @miken32 you are touching the foundation of module.xml, hence we need to do proper testing before accepting this PR, thats the reason for delay in merging/review this PR. |
Contributor
Author
|
Sounds good, was just looking for some kind of acknowledgement. |
Contributor
Author
|
Any updates @kguptasangoma ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves FreePBX/issue-tracker #761 by passing arrays to Doctrine's FK creation method. This syntax doesn't seem to be documented anywhere so no updates to documentation needed? (hint: it probably should be documented somewhere)
Also took the opportunity to clean up the code a bit and remove some checks that were a) outdated and b) preventing proper character sets from being applied ("pdo_mysql" is not used in DSN strings, and safe to say nobody is using MySQL 5.5 any more.)
I know it looks like I rewrote the entire file, but view the diff with whitespace changes hidden and it will look a lot more reasonable!