Conversation
|
|
| "config": { | ||
| "platform": { | ||
| "php": "8.1.0" | ||
| "php": "8.2.29" |
There was a problem hiding this comment.
Changing composer may affect other dependent packages to get update as well. May be revert this fix and we can merge other fixes.
We can fix composer and dependent packages in next major release.
There was a problem hiding this comment.
Hi @kguptasangoma, thank you for taking the time to review this.
While it's true that updating composer.json, especially the dependencies, can cause packages to be upgraded, I still believe this is an issue.
The config.platform.php file is unique because it sets the PHP version to be used rather than having it determined at runtime. From all the docs I have read, I believe the supported version of PHP is 8.2. This will correctly constrain versions of the packages.
I know this is somewhat of an edge case, only affecting developers, but with the composer.lock file stacking the same and all the vendor code being committed into the repository, I believe this to have minimal impact.
There was a problem hiding this comment.
I believe this to have minimal impact.
I can understand by seeing code , this looks minimal impact but v17 is quite GA now and without testing we can not push any such changes into production. I still feel changing such 3rd party core library level changes should publish to major Freepbx release.
Keeping this Pr open to consider for Freepbx v18.
Regards,
Kapil
2 participants
PHP Version Mismatch
According to the documentation of FreePBX 17, PHP 8.2 is now the minimum required version of PHP to install. However, when reviewing the installation scripts, it's possible to use lower versions, which may cause side effects and differing behaviour.
Changes
Set PHP 8.2 as the minimum version for install