Fix multiplying users in room#4
Draft
Frenzyz wants to merge 1 commit into
Draft
Conversation
…ections Co-authored-by: aadister16 <aadister16@gmail.com>
|
|
✅ Deploy Preview for mtcha ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes user multiplication in WebRTC calls by ensuring single connections and proper user management.
The previous implementation allowed multiple socket connections per user, generated accumulating reconnection IDs, and lacked proper server-side cleanup of old user instances, leading to users appearing multiple times in a room. This PR addresses these by enforcing single socket connections, using clean base IDs for reconnections, implementing robust server-side user cleanup, adding reconnection guards, and ensuring the WebRTC service is a singleton.
Learn more about Cursor Agents