fix(folia): use entity scheduler for getState() to avoid off-region t…#61
Closed
wizzoh wants to merge 1 commit intoFreshSMP:feature/foliafrom
Closed
fix(folia): use entity scheduler for getState() to avoid off-region t…#61wizzoh wants to merge 1 commit intoFreshSMP:feature/foliafrom
wizzoh wants to merge 1 commit intoFreshSMP:feature/foliafrom
Conversation
…hread errors On Folia, every entity is owned by a specific region thread. The previous implementation used `regionScheduler.run(location, ...)` to schedule entity state access, but this targets the region that *contains the given location* rather than the region that *owns the entity*. In edge cases (chunk boundary transitions, region re-assignments) these can differ, causing: IllegalStateException: Accessing entity state off owning region's thread Two bugs are fixed: 1. Switch from `Bukkit.getServer().getRegionScheduler().run(location, task)` to `entity.getScheduler().execute(plugin, task, retired, delay)`. The EntityScheduler always dispatches on the entity's actual owning region thread, regardless of the entity's current location. 2. Force-evaluate the lazy NBT tag (`base.getNbt()`) while still inside the entity scheduler callback. `LazyBaseEntity.getNbt()` delegates to `TaskManager.sync()`, which on Folia short-circuits and runs the supplier directly on the calling thread. Without this eager evaluation the supplier would run later on an async copy thread, also off the owning region. Also remove the now-unused `import org.bukkit.Bukkit` statement. https://claude.ai/code/session_01LCRiqfY5a3h2Ccmonp6Jpn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hread errors
On Folia, every entity is owned by a specific region thread. The previous implementation used
regionScheduler.run(location, ...)to schedule entity state access, but this targets the region that contains the given location rather than the region that owns the entity. In edge cases (chunk boundary transitions, region re-assignments) these can differ, causing:IllegalStateException: Accessing entity state off owning region's thread
Two bugs are fixed:
Switch from
Bukkit.getServer().getRegionScheduler().run(location, task)toentity.getScheduler().execute(plugin, task, retired, delay). The EntityScheduler always dispatches on the entity's actual owning region thread, regardless of the entity's current location.Force-evaluate the lazy NBT tag (
base.getNbt()) while still inside the entity scheduler callback.LazyBaseEntity.getNbt()delegates toTaskManager.sync(), which on Folia short-circuits and runs the supplier directly on the calling thread. Without this eager evaluation the supplier would run later on an async copy thread, also off the owning region.Also remove the now-unused
import org.bukkit.Bukkitstatement.