Prepare for CakePHP 5.x by kevindecapite · Pull Request #194 · FriendsOfCake/crud-json-api

kevindecapite · 2025-06-27T01:10:39Z

Preparation PR that removes deprecations for upgrading to CakePHP 5.0.0.

- TestListenerTrait is used by Cake\TestSuite\Fixture\FixtureInjector; but - It's removed in CakePHP 5.0.0 and will no longer throw deprecations.

https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

kevindecapite · 2025-06-27T01:30:40Z

Refs

What is required to make this compatible with Cake 5.x? #193

ADmad · 2025-06-27T02:46:17Z

phpunit constraints need to be updated to ^10.5.5 || ^11.1.3 || ^12.0.9 and codesniffer to ^5.1 to get the CI passing.

kevindecapite · 2025-06-27T13:39:57Z

@ADmad Thank you. I can't use phpunit 10+ with Cake 4.6 so I assume I should just do the full Cake 5 upgrade in this PR rather than separating the process into two separate ones?

ADmad · 2025-06-27T17:18:06Z

Oh, I assumed this was upgrade to Cake 5 since you dropped PHP 7.4 in CI.
The Cake 4 compatible version needs to keep PHP 7.4 support as the core does.

kevindecapite · 2025-06-27T19:03:59Z

Originally I was going to do the full upgrade to Cake 5 in a single PR, then I thought I would separate the work into two separate PRs. Now I think I will return to the original idea and do the full upgrade to Cake 5 here.

- cakephp/cakephp:^5.0.0 - friendsofcake/crud:^7.0.0 - phpunit/phpunit:^10.5.5 || ^11.1.3 || ^12.0.9 - friendsofcake/cakephp-test-utilities:^3.0.0 - friendsofcake/search:^7.0.0 - cakephp/cakephp-codesniffer:^5.1 - dms/phpunit-arraysubset-asserts:^0.5.0

…of order().

…ia query.

ADmad · 2025-06-30T07:47:08Z

The Static Analysis job is failing due to some psalm issue. We can just drop pslam and keep only phpstan.

…again.

kevindecapite · 2025-06-30T17:13:31Z

I'll need help getting the coding standard and static analysis tests passing because code sniffer wants to add typehints that break inheritance requirements.

Regarding phpstan, it seems it doesn't like the magic serialize() and unserialize() methods.

kevindecapite · 2025-06-30T17:22:46Z

-        "laravel-json-api/neomerx-json-api": "^5.0"
+        "php": ">=8.1.0",
+        "cakephp/cakephp": "^5.0.0",
+        "friendsofcake/crud": "^7.2.0",


Is this ok? It seems needed due to this change:

https://github.com/FriendsOfCake/crud/pull/754/files#diff-5aa78d26d9d06925cb6d1434c1c8afa3962704f1041ef3ecf1cb25561e66ee43L124

…y().

kevindecapite · 2025-07-02T16:30:49Z

Can I help with anything else or is this finished now?

kevindecapite added 6 commits June 26, 2025 13:24

Fix PHPUnit 9 deprecations.

b862395

vendor/bin/phpunit --migrate-configuration

c2b8fdd

Fix CakePHP 4.x deprecations.

b427932

- TestListenerTrait is used by Cake\TestSuite\Fixture\FixtureInjector; but - It's removed in CakePHP 5.0.0 and will no longer throw deprecations.

Upgrade to new fixture management per CakePHP 4.3.0.

728ba22

Refactor match() to switch in JsonApiListenerTest.

d2862c0

Use actions/cache@v4 in GitHub workflow ci.yml.

c35b6a9

https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

Make PHP 8.1 lowest-supported version.

be0deb2

kevindecapite added 11 commits June 29, 2025 17:28

Set composer.json requirements:

d7939c3

- cakephp/cakephp:^5.0.0 - friendsofcake/crud:^7.0.0 - phpunit/phpunit:^10.5.5 || ^11.1.3 || ^12.0.9 - friendsofcake/cakephp-test-utilities:^3.0.0 - friendsofcake/search:^7.0.0 - cakephp/cakephp-codesniffer:^5.1 - dms/phpunit-arraysubset-asserts:^0.5.0

Change type declarations and method signatures per Cake 5 upgrade.

373cf25

ORM: fetchTable() instead of ProxyTrait::_table(); orderBy() instead …

857a997

…of order().

Remove RequestHandler component from test_app controllers.

0188935

Update tests/bootstrap.php per Cake 5 upgrade.

3ccf903

Update PaginationListener.

6847552

Add missing use statements for Cake functions.

5c4e201

Add missing routes to test_app routes.

3d5a764

Change JsonApiListener::_getSingleEntity() return to support entity v…

3661893

…ia query.

Refactor tests per PHPUnit 10.5.5 upgrade.

0620078

Fix PHPUnit 10 deprecations.

5df1c30

kevindecapite commented Jun 30, 2025

View reviewed changes

Comment thread src/Listener/JsonApiListener.php Outdated

kevindecapite commented Jun 30, 2025

View reviewed changes

Comment thread tests/TestCase/Listener/JsonApiListenerTest.php Outdated

ADmad reviewed Jun 30, 2025

View reviewed changes

Comment thread src/Listener/JsonApiListener.php Outdated

Comment thread src/Plugin.php Outdated

Comment thread tests/TestCase/Error/JsonApiExceptionRendererTest.php Outdated

Comment thread tests/TestCase/Error/JsonApiExceptionRendererTest.php Outdated

kevindecapite added 3 commits June 30, 2025 06:55

Remove psalm from GH workflow.

80c215b

Apply codesniffer checks & fixes; manual fixes as needed.

5256734

Fix phpstan issues.

23c8820

kevindecapite added 10 commits June 30, 2025 07:28

composer require laravel-json-api/neomerx-json-api:^5.0.2

5c4ded2

Fix type declaration breakages from codesniffer cleanup.

a9d937c

composer require friendsofcake/crud:^7.2.0

de4117b

Use SelectQuery instead if Query in JsonApiListener.

026e417

Re-use InstanceConfigTrait in JsonApiView to make getConfig() public …

3108fbb

…again.

Add _cake_core_ cache config to tests/bootstrap.php for BC.

eaff92b

Define many-to-many CountriesLanguages through model in test_app.

fceb68a

Replace switch with match() in JsonApiListenerTest.

f6d94fb

Rename plugin to CrudJsonApiPlugin.

7522a88

Remove ModelAwareTrait from JsonApiExceptionRendererTest.

d143d75

Use fully qualified names where appropriate.

a146267

kevindecapite commented Jun 30, 2025

View reviewed changes

kevindecapite and others added 5 commits July 1, 2025 09:07

Make entity return check sensible in JsonApiListener::_getSingleEntit…

a0a1bee

…y().

Fix CS errors

df37bbc

Fix phpstan errors

a5f76b5

Fix CS errors

7695d33

Update CI config

a67d5be

ADmad merged commit 34075ca into FriendsOfCake:master Jul 2, 2025
7 checks passed

kevindecapite deleted the issue-193 branch July 2, 2025 19:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for CakePHP 5.x#194

Prepare for CakePHP 5.x#194
ADmad merged 37 commits intoFriendsOfCake:masterfrom
kevindecapite:issue-193

kevindecapite commented Jun 27, 2025

Uh oh!

kevindecapite commented Jun 27, 2025

Uh oh!

ADmad commented Jun 27, 2025

Uh oh!

kevindecapite commented Jun 27, 2025

Uh oh!

ADmad commented Jun 27, 2025

Uh oh!

kevindecapite commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADmad commented Jun 30, 2025

Uh oh!

kevindecapite commented Jun 30, 2025 •

edited

Loading

Uh oh!

kevindecapite Jun 30, 2025

Uh oh!

kevindecapite commented Jul 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kevindecapite commented Jun 27, 2025

Uh oh!

kevindecapite commented Jun 27, 2025

Uh oh!

ADmad commented Jun 27, 2025

Uh oh!

kevindecapite commented Jun 27, 2025

Uh oh!

ADmad commented Jun 27, 2025

Uh oh!

kevindecapite commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADmad commented Jun 30, 2025

Uh oh!

kevindecapite commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevindecapite Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

kevindecapite commented Jul 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kevindecapite commented Jun 30, 2025 •

edited

Loading