Skip to content

Update deprecation warning version in SearchTrait#369

Merged
ADmad merged 1 commit intoFriendsOfCake:masterfrom
LordSimal:master
Nov 19, 2025
Merged

Update deprecation warning version in SearchTrait#369
ADmad merged 1 commit intoFriendsOfCake:masterfrom
LordSimal:master

Conversation

@LordSimal
Copy link
Copy Markdown
Contributor

@LordSimal LordSimal commented Nov 18, 2025

Caused by #365

I'd also recommend adjusting the docs in https://github.com/FriendsOfCake/search/blob/master/docs/filter-collections.md#collection-class-vs-table-config to now show this deprecated example

Updated deprecation warning version from 1.7.1 to 7.7.1.
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.35%. Comparing base (c75326b) to head (7132608).
⚠️ Report is 55 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #369      +/-   ##
============================================
+ Coverage     90.78%   91.35%   +0.57%     
- Complexity      225      240      +15     
============================================
  Files            19       19              
  Lines           651      694      +43     
============================================
+ Hits            591      634      +43     
  Misses           60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ADmad ADmad merged commit ab9c864 into FriendsOfCake:master Nov 19, 2025
9 checks passed
@ADmad
Copy link
Copy Markdown
Member

ADmad commented Nov 19, 2025

I'd also recommend adjusting the docs..

That example is already updated to call searchManager() on the behavior instance instead of the table instance.

@LordSimal
Copy link
Copy Markdown
Contributor Author

but it still overwrites the searchManager method which contradicts the deprecation message.
I have adjusted all my code to this now:
image

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Nov 19, 2025

My bad, I was thinking of the change I had done here https://github.com/FriendsOfCake/search/blob/master/docs/basic-configuration.md?plain=1#L31

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Nov 19, 2025

@LordSimal I have updated the docs

I have adjusted all my code to this now

You should just switch to filter collections instead :)

  • Bake the collection with name matching your table name, bake filter_collection DeploymentIgnores
  • Move the contents of the setupSearchManager() method to the filter's intialize() and change the references from $searchManger to $this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants