dmap fixes - #41
Merged
Merged
Conversation
Closes the 205→186 shadowModel and 40.7→21.0 MB gap that was producing
specular rainbow and dancing shadow artifacts in feedingtowerd.
Verified via Ghidra + gdb reference captures, A/B BSP vertex bit
comparison, and shadowModel set diffs against commercial 1.2 and 1.4.
Final results: 186 shadowModels, 2,373 surfaces, 21.04 MB —
geometrically identical to what's in commercial pakfiles.
usurface.cpp inline-merge skip filters:
- IsDefaultModel() results (unregistered inline func_static_N
entities were merging bogus 24-vert _default boxes).
- Non-drawn, non-shadow surfaces (matches TriListForSide; was
leaking collision_* into worldspawn).
- Materials with ConstantRegisters()==NULL: these reference
per-entity shaderParm0..6 (ft_lightpod, buglight2) and lose their
parm values when folded into worldspawn.
Winding.cpp x87 parity for BSP topology:
- Plane distance + dot in double (Split/Clip/ClipInPlace/PlaneSide)
so SelectSplitPlaneNum scoring matches.
- Split-point lerp in long double (x86_64 native 80-bit) to match
HumanHead's builds with x87 intermediate precision.
…ecision was overkill. Discovered and Worked around some segfaults, hangs, and stack-smashing situ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result of a just a wee bit of R&D to get to commercial dmap parity (c/o issue #36, #38)
creating a PR before I forget about it