Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
- Create user
- add API with API docs
- Update color picker to use new design
- click to access feedback details for items in personal feedback list
- Notifications infrastructure
- Anonymous feedback claiming
- Email verification nudge
Expand Down
7 changes: 4 additions & 3 deletions pages/dashboard/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@
</p>
</div>
<div v-else class="space-y-3">
<div
<NuxtLink
v-for="item in recentSubmissions"
:key="item.id"
class="flex items-center justify-between rounded-lg border p-3"
:to="`/feedback/${item.id}`"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid linking personal submissions to team-only detail route

The new :to="/feedback/${item.id}" link is rendered only in the personal-dashboard branch (!hasOrganization), but that detail flow calls GET /api/feedback/:id, which enforces requireProjectAccess for authenticated users (server/api/feedback/[id]/index.get.ts) and returns 403 when the user is not a team member (server/utils/project-access.ts). For users in this branch (no org/team membership), clicking a recent submission now consistently lands on an access error instead of showing details, so the new navigation path is functionally broken for its target audience.

Useful? React with 👍 / 👎.

class="flex items-center justify-between rounded-lg border p-3 hover:bg-muted transition-colors"
>
<div class="min-w-0 flex-1">
<p class="font-medium truncate">{{ item.title }}</p>
Expand All @@ -106,7 +107,7 @@
{{ item.voteCount }}
</span>
</div>
</div>
</NuxtLink>
</div>
</CardContent>
</Card>
Expand Down
Loading