You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This prop can be used to set a classname for scoped styles, such as guideline blocks.
The value is passed to all portals through the theme context, so also apply in dialogs etc.
I avoided using the name className as it is misleading in what the prop does. It does not set the classname of the Provider component, but add one additional class to the existing set.
Context merging
Previously, every nested ThemeProvider overrode the theme context with the default values.
We now merge the context and only override the values explicitly passed to the nested ThemeProvider
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Lead time: 3 hours, 20 minutes, 59 seconds (3.35 total hours) from first commit to close.
Review time: 3 hours, 12 minutes, 30 seconds (3.21 total hours) from ready for review to close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
scopeClassNamepropThis prop can be used to set a classname for scoped styles, such as guideline blocks.
The value is passed to all portals through the theme context, so also apply in dialogs etc.
I avoided using the name
classNameas it is misleading in what the prop does. It does not set the classname of the Provider component, but add one additional class to the existing set.Context merging
Previously, every nested
ThemeProvideroverrode the theme context with the default values.We now merge the context and only override the values explicitly passed to the nested
ThemeProvider