Hair Color Enhancements - #79
Merged
Merged
Conversation
Also adding better defaults. It now defaults to Madeline's hair colors, instead of black.
technically, the unchanged ones are optional now, but I left them there for reference on granny and badeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates how we handle Hair Colors to now allow support for Hex strings, instead of only decimal ints. This should simplify how colors are entered for strings in most cases. It's set up in a way that either format is supported, so we shouldn't be breaking compatibility with existing skins.
I also updated the default values so they now will default to madeline's colors by default, instead of defaulting to black. This means that colors will now be optional, and you should only need to change hair colors that actually are different than the default. Technically, this could cause a breaking change if anyone was expecting it to be default and have black hair, but none of the released skin mods seem to be doing that, so I think that we're probably in the clear.
I also updated the default skins to now use hex instead, since I assume that will now become the preferred way of doing it, and those are probably going to be seen as an example by modders. For Badeline and Granny, I filled out all the colors, even though I probably didn't need to, just so they could be used as examples by modders. We can maybe revisit this when we have a proper skin template repo though.